Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase waitFor duration for KSM E2E tests #1385

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

Increase waitFor duration for KSM end-to-end tests.

Motivation

Fix flaky test. It sometimes takes a while for the cluster agent and/CCR pods to start running the KSM check.

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@fanny-jiang fanny-jiang added bug Something isn't working qa/skip-qa labels Aug 29, 2024
@fanny-jiang fanny-jiang requested a review from a team as a code owner August 29, 2024 19:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.29%. Comparing base (6c3ea8f) to head (4359e00).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1385   +/-   ##
=======================================
  Coverage   47.29%   47.29%           
=======================================
  Files         217      217           
  Lines       18710    18710           
=======================================
  Hits         8849     8849           
  Misses       9399     9399           
  Partials      462      462           
Flag Coverage Δ
unittests 47.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3ea8f...4359e00. Read the comment docs.

@fanny-jiang fanny-jiang merged commit 9f9a13c into main Aug 29, 2024
23 checks passed
@fanny-jiang fanny-jiang deleted the fanny/e2e-ksm-increase-waitFor branch August 29, 2024 19:36
mftoure pushed a commit that referenced this pull request Oct 3, 2024
mftoure pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants